Feature/compose click node name from modifier #1415
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 7e36c1efb2c450051da424d868be2a5fbaad5628)
(cherry picked from commit 7883fbdd4bd53a2c41f96fb0a0f1a6db4a27d100)
(cherry picked from commit a088638b217ec60e707adad03c04bbb2be35f8d1)
(cherry picked from commit c2b4483761a40eed2a771e74190c7b25e57f8134)
…/compose-click-node-name-from-modifier
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #1415 +/- ##
==========================================
+ Coverage 63.10% 63.41% +0.30%
==========================================
Files 158 160 +2
Lines 3128 3154 +26
Branches 324 331 +7
==========================================
+ Hits 1974 2000 +26
Misses 1059 1059
Partials 95 95 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enchances the compose-click module for better detection of the name of tapped compose element.
It introduces two ways of detecting name of the tapped element:
Modifier.opentelemetry- introduces a custom Modifier (similar solution is used by other telemetry SDKs like Datadog and Sentry. Developers can use this modifier to mark a composable element and give it a name. Then the compose-click module will be able to easily find such tapped element and retrieve a name from it.Modifier.testTag- handling as a fallback to read the TestTag value of tapped element. TestTag is often used for Unit tests and therefore it is useful to take it during composable element name discovery.